[MOD-15868/MOD-15876] env: allow substituting Env subclass via Defaults.env_class#254
Open
ofiryanai wants to merge 1 commit into
Open
[MOD-15868/MOD-15876] env: allow substituting Env subclass via Defaults.env_class#254ofiryanai wants to merge 1 commit into
ofiryanai wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small, generic construction hook so a consumer can substitute an
Envsubclass for bareEnv(...)construction, without monkeypatching:Defaults.env_class(defaultNone)Env.__new__returnsDefaults.env_classwhen the bareEnvis constructed and a class is set (thepathlib.Path→PosixPathidiom).When
env_class is Nonebehavior is unchanged, so this is a no-op for existing users. It lets the RediSearch pytest suite run against the enterprise module via a properEnvsubclass (RediSearch#10205) instead of monkeypatchingEnvin place — covering both fixture-injecteddef testX(env)tests (viaDefaults.env_factory) and the ~45 files that constructEnv(...)directly.No RediSearch-specific logic here; all module-specific behavior stays in the RediSearch suite.
🤖 Generated with Claude Code