Storage: add VirtualMachineBackup and VirtualMachineBackupTracker resources#2745
Open
dalia-frank wants to merge 2 commits into
Open
Storage: add VirtualMachineBackup and VirtualMachineBackupTracker resources#2745dalia-frank wants to merge 2 commits into
dalia-frank wants to merge 2 commits into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdds Changesbackup.kubevirt.io Resource Definitions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ocp_resources/virtual_machine_backup_tracker.py`:
- Line 1: The header marker on line 1 in virtual_machine_backup_tracker.py does
not conform to the project's class-generator convention for ocp_resources.
Update the generator template (located in the class-generator tool referenced in
the comment) to use the correct start marker format as specified in the project
coding guidelines, then regenerate the virtual_machine_backup_tracker.py file
using the class-generator to ensure the generated-section tooling and review
behavior remains consistent with repository standards.
In `@ocp_resources/virtual_machine_backup.py`:
- Line 1: The generated-code start marker comment in virtual_machine_backup.py
uses a non-standard generator URL that does not match the repository standards
required for files in the ocp_resources directory. Update the class-generator
template to emit the correct repository-standard generated-code start marker,
then regenerate the virtual_machine_backup.py file to replace the current
marker, rather than manually editing the generated output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f02901a6-0bcd-4a33-a4e0-39b14c879a7c
⛔ Files ignored due to path filters (3)
class_generator/schema/__cluster_version__.txtis excluded by!class_generator/schema/**class_generator/schema/__resources-mappings.json.gzis excluded by!**/*.gz,!class_generator/schema/**class_generator/schema/_definitions.jsonis excluded by!class_generator/schema/**
📒 Files selected for processing (3)
ocp_resources/resource.pyocp_resources/virtual_machine_backup.pyocp_resources/virtual_machine_backup_tracker.py
Contributor
Author
|
/verified |
Collaborator
|
/retest security-committer-identity |
Add generated backup.kubevirt.io resources with Push/Pull mode constants and update class-generator schema for the new CRDs. Signed-off-by: Dalia Frank <dfrank@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
dalia-frank
force-pushed
the
add-cbt-backup-resources
branch
from
6c750a3 to
8ba49d9
Compare
Contributor
|
Clean rebase detected — no code changes compared to previous head ( |
Pre-commit hook detected missing newlines in schema files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dalia-frank
force-pushed
the
add-cbt-backup-resources
branch
from
2277040 to
62d66a1
Compare
|
Clean rebase detected — no code changes compared to previous head ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Add generated backup.kubevirt.io resources with Push/Pull mode constants and update class-generator schema for the new CRDs.
More details:
https://github.com/kubevirt/enhancements/blob/main/veps/sig-storage/incremental-backup.md
What this PR does / why we need it:
Adds the VirtualMachineBackup and VirtualMachineBackupTracker Custom Resource Definitions (CRDs) required to support the Change Block Tracking (CBT) feature for incremental backups.
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:
Summary by CodeRabbit