Skip to content

RHINENG-27056: update cji db-migration job with name using image_tag and suffix #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TenSt merged 1 commit into from
Jun 24, 2026
+5 −1
Merged

RHINENG-27056: update cji db-migration job with name using image_tag and suffix #2246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion deploy/clowdapp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ objects:
clowder.redhat.com/expected-image-tag: ${IMAGE_TAG}
labels:
app: patchman
generateName: db-migration-
name: db-migration-${IMAGE_TAG}-${CJI_UID}

@sourcery-ai sourcery-ai Bot Jun 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Including IMAGE_TAG in the resource name risks invalid characters or excessive length for Kubernetes object names.

Kubernetes names must be DNS-1123 compliant and ≤253 chars, but IMAGE_TAG values often contain :// (e.g. quay.io/...:1.2.3), which would make this name invalid and long tags could exceed the limit. Please either sanitize/slugify IMAGE_TAG before using it here (e.g. drop the repo part and replace invalid chars) or derive a shorter, valid identifier (e.g. a hash).

spec:
appName: patchman
runOnNotReady: true
Expand Down Expand Up @@ -772,6 +772,10 @@ parameters:

# DB migration
- {name: DB_MIGRATION_DISABLED, value: 'false'} # Disable db-migration job execution
- name: CJI_UID
description: Unique db-migration CJI name suffix
generate: expression
from: '[a-z0-9]{6}'
# VMaaS sync
- {name: VMAAS_SYNC_SCHEDULE, value: '*/5 * * * *'} # Cronjob schedule definition
- {name: VMAAS_SYNC_SUSPEND, value: 'false'} # Disable cronjob execution
Expand Down
Loading