RHINENG-27056: add cji for the db-migration job#2245
Merged
TenSt merged 1 commit intoJun 24, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a ClowdJobInvocation (CJI) resource to trigger the db-migration job and introduces a parameter to optionally disable this job via configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The inline comment for
DB_MIGRATION_DISABLED(“Disable db-migration job execution”) is slightly confusing given the defaultfalsevalue (which means the job is enabled); consider clarifying the wording to reflect thattruedisables the job. - Double-check that
disabled: ${{DB_MIGRATION_DISABLED}}will be rendered as a proper boolean in the generated manifest (not a string), or explicitly coerce it if the templating system does not handle that automatically.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline comment for `DB_MIGRATION_DISABLED` (“Disable db-migration job execution”) is slightly confusing given the default `false` value (which means the job is enabled); consider clarifying the wording to reflect that `true` disables the job.
- Double-check that `disabled: ${{DB_MIGRATION_DISABLED}}` will be rendered as a proper boolean in the generated manifest (not a string), or explicitly coerce it if the templating system does not handle that automatically.
## Individual Comments
### Comment 1
<location path="deploy/clowdapp.yaml" line_range="769-771" />
<code_context>
- {name: JOBS_CONFIG, value: ''}
+# DB migration
+- {name: DB_MIGRATION_DISABLED, value: 'false'} # Disable db-migration job execution
# VMaaS sync
- {name: VMAAS_SYNC_SCHEDULE, value: '*/5 * * * *'} # Cronjob schedule definition
</code_context>
<issue_to_address>
**suggestion:** Clarify the default value vs. inline comment for `DB_MIGRATION_DISABLED`
The name `DB_MIGRATION_DISABLED` with default `'false'` and the comment “Disable db-migration job execution” is misleading, since `'false'` actually means “do not disable.” Please update the comment to describe the behavior more explicitly (e.g., “Set to 'true' to disable db-migration job execution”), or, if feasible, rename/invert the flag so its value matches the described behavior.
```suggestion
# DB migration
- {name: DB_MIGRATION_DISABLED, value: 'false'} # Set to 'true' to disable db-migration job execution
# VMaaS sync
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
jlsherrill
previously approved these changes
Jun 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
- Coverage 59.06% 59.04% -0.03%
==========================================
Files 138 138
Lines 8848 8848
==========================================
- Hits 5226 5224 -2
- Misses 3076 3078 +2
Partials 546 546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f537a10 to
81e3623
Compare
jlsherrill
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Summary by Sourcery
Add configuration to invoke the db-migration job as a ClowdJobInvocation in the patchman application.
New Features:
Build: