fix(bitbox): sign the registration with a chainId-extended EIP-712 domain#877
Draft
Blume1977 wants to merge 1 commit into
Draft
fix(bitbox): sign the registration with a chainId-extended EIP-712 domain#877Blume1977 wants to merge 1 commit into
Blume1977 wants to merge 1 commit into
Conversation
…main The BitBox02 firmware refuses to sign typed data whose EIP712Domain has no chainId and aborts with 'typed data has no chain ID' on the device, so BitBox users could not complete the registration at all. Hardware wallets now sign with the chainId-extended domain; software wallets keep the legacy domain (pinned by the golden signature test) until Aktionariat confirms its re-verification accepts the extended variant. Pair PR: DFXswiss/api#4354 (accepts both domain variants, must deploy first).
14 tasks
TaprootFreak
requested changes
Jul 24, 2026
TaprootFreak
left a comment
TaprootFreak
left a comment
Contributor
There was a problem hiding this comment.
wir brauchen mehr daten um sicher zu sein ob das der echte fix ist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BitBox users cannot complete the RealUnit registration: on submit, the BitBox02 (Nova) rejects the signing request and shows "typed data has no chain ID" on the device (first affected customer: userData 412822, 23.07.). The firmware requires a
chainIdmember in the EIP712Domain; our registration payload signs the chainId-less domain{ name: 'RealUnitUser', version: '1' }. Software wallets sign it regardless, which is why this never surfaced.Change
Eip712Signer.signRegistrationincludeschainId(value:apiConfig.asset.chainId, already plumbed through) in the EIP712Domain for BitboxCredentials only.Pair PR / merge order
Open coordination point before release
Aktionariat re-verifies the registration signature. If their check is pinned to the legacy domain, chainId-signed (BitBox) registrations will fail on their side as "Invalid signature" at forward time. Needs confirmation from Aktionariat (via Dani) that their verification accepts the chainId-extended domain. Restricting the new domain to hardware wallets keeps the blast radius at "BitBox stays blocked at a later stage" in the worst case — strictly no regression for software wallets.
Tests
domain.chainId+chainIdmember in EIP712Domain types