Avoid using structure() in tests#7814
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7814 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17228 17234 +6
=======================================
+ Hits 17059 17065 +6
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Generated via commit bb021b4 Download link for the artifact containing the test results: ↓ atime-results.zip
|
ben-schwen
reviewed
Jul 14, 2026
ben-schwen
reviewed
Jul 14, 2026
ben-schwen
reviewed
Jul 14, 2026
ben-schwen
approved these changes
Jul 14, 2026
ben-schwen
left a comment
Member
There was a problem hiding this comment.
Overall LGTM
When setting class() and subsequently setting attr() we could also set both with attributes()
Member
Author
Not quite so simple, e.g. for building |
aitap
pushed a commit
that referenced
this pull request
Jul 15, 2026
* Progress removing structure() using in general * a few more * complete 1st pass * typo * typo2 * typo3 * typo4 * vestigial * typo5 * style * drop nolints * remove all undesirable markings esp. with ForderObj constructor * use by-reference-ness * learn to read; skip optional attr * use setNames not names<- * review feedback * one case where attributes<- is good * typo DF->DF1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #7813.
structure()is slow, and, as we saw there, can be a bit fragile. It's better to use the greenlit path to construct objects where possible.