Add tests for UI nested components#10337
Draft
laggron42 wants to merge 3 commits intoRapptz:masterfrom
Draft
Conversation
5c03feb to
64c7666
Compare
Contributor
Author
|
To clear some confusion, I wrote this minimal test to demonstrate the case that is still failing. Buttons are instanciated using decorators, both inside import asyncio
from discord.ui import *
class MyActionRow(ActionRow):
@button()
async def btn1(self, inter, btn):
pass
class MyContainer(Container):
myrow = MyActionRow()
@myrow.button()
async def btn2(self, inter, btn):
pass
class MyView(LayoutView):
container = MyContainer()
async def main():
view = MyView()
print(view.container.view) # <MyView timeout=180.0 children=1>
print(view.container.myrow.view) # <MyView timeout=180.0 children=1>
print(view.container.myrow.btn1.view) # None
print(view.container.btn2.view) # None
asyncio.run(main())Both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds checks to ensure the
viewandparentproperties of UI components are properly set when there are multiple layers of nesting. It also checks that allinteraction_checkmethods are called.Resolves #10335 when the tests pass.
Test details
The test will build the following nested objects: LayoutView > Container > ActionRow > Item (Button or Select)
They are constructed in 3 ways for each test:
Container(ActionRow(Item())))add_itemmethods (c=Container();c.add_item(...))Current failing test cases:
item.parentnot set for items created via class constructorsitem.parentreturns a different instance thanrowbut of correct type for a button created via decoratoritem.parent.parentset toNoneinstead ofcontainerChecklist