[TEST] CI build of the LED rainbow follow-ups (do not merge) - #10
Draft
Raffi1202 wants to merge 3 commits into
Draft
[TEST] CI build of the LED rainbow follow-ups (do not merge)#10Raffi1202 wants to merge 3 commits into
Raffi1202 wants to merge 3 commits into
Conversation
Follow-ups to the rainbow overlay review:
- COLOR_WHITE was changed to {0, 0, 255}; hsvToRgb24() stores saturation
inverted, so that renders pure red and would have hit every user of the
palette entry after the PG bump. Restore {0, 255, 255}.
- With eight overlays the CLI led string can reach 25 characters
("15,15:NESWUD:CTOBNIWEV:15"), more than the 20-byte stack buffers in
printLed(). Size them with LED_CONFIG_STRING_LENGTH (32) and format
with tfp_snprintf() so generateLedConfig() can never overrun its
buffer.
- The rainbow layer overwrote every field of the colour it read; build
the colour directly.
- Restore the executable bit on update_cli_docs.py.
|
RAM / Flash usage vs. base branch — commit
See RAM/flash optimization guide for techniques to reduce usage. |
Reuse the CI fixes from iNavFlight#11885 and cover scalar, array and conditional registrations with regression fixtures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal draft PR to build https://github.com/Raffi1202/inav/tree/fix/led-rainbow-followups, the review follow-ups on top of iNavFlight#11820. Not for merging here.