Repository navigation
docs: restructure ROCm installation section and add vLLM adapter topic #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
12b68a7
5246131
c4e327f
f4caacc
57db2d7
b8bf19c
0e40c27
a6fe23a
3c27c19
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <!-- | ||
| Copyright © Advanced Micro Devices, Inc., or its affiliates. | ||
|
|
||
| SPDX-License-Identifier: MIT | ||
| --> | ||
|
|
||
| ```{include} ../../vllm.md | ||
| ``` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,10 +15,24 @@ SPDX-License-Identifier: MIT | |
|
|
||
| ```{include} ../../README.md | ||
| :start-after: "## Configure ROCm and serve a model" | ||
| :end-before: "Running the command when a" | ||
| ``` | ||
|
|
||
| <!-- The prose below is a deliberate copy of the README sentence, with the | ||
| cross-reference retargeted to this site. The link text is then reused as | ||
| the `:start-after:` anchor for the next include, which also matches the | ||
| original sentence in README.md; edit both together. --> | ||
| Running the command when a managed runtime is already the active default asks | ||
| first, because the new install takes over as the active default; see | ||
| [ROCm installation](commands.md#rocm-installation) for that gate and the flags | ||
| that approve it without a prompt. | ||
|
|
||
| ```{include} ../../README.md | ||
| :start-after: "for that gate and the flags that approve it without a prompt." | ||
| :end-before: "You can also serve any compatible Hugging Face model directly" | ||
| ``` | ||
|
|
||
| You can also serve any compatible Hugging Face model directly — see | ||
| You can also serve any compatible Hugging Face model directly. See | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This duplicates the previous two lines ("You can also serve any compatible Hugging Face model directly — see / [Model serving]... for the GGUF-vs-safetensors rule,") with slightly different wording ("directly. See" vs "directly — see"). The old pair is still there right above as unchanged context — only one of the two should remain. Note the code comment a few lines up says to edit this sentence in lockstep with README.md's copy; README.md's own copy ( |
||
| [Model serving](commands.md#model-serving) for the GGUF-vs-safetensors rule, | ||
| since which form works depends on the engine your GPU selects. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file
{include}sdocs/vllm.mdinto the built Sphinx site for the first time, but.github/workflows/ci.yml'sdocs:path filter (around lines 165-174) only watchesdocs/rocm-docs/**,README.md,CONTRIBUTING.md,.readthedocs.yaml, and.github/workflows/**— it doesn't listdocs/vllm.md. A future PR that editsdocs/vllm.mdalone (a broken include, a bad code fence) won't trigger the "Sphinx docs build (-W)" check that would catch it, even though this page now ships in the site. Worth addingdocs/vllm.mdto thedocs:filter list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juhovainio. I've added
docs/vllm.mdto the path filter in.github/workflows/ci.ymland extended the comment above it.