Skip to content

Fix Dependabot configurations and update gRPC to patched version - #96

Merged
sarat-k merged 4 commits into
ROCm:mainfrom
spraveenio:main
Sep 11, 2026
Merged

sarat-k merged 4 commits into
ROCm:mainfrom
spraveenio:main

Conversation

@spraveenio

Copy link
Copy Markdown
Contributor

This pull request updates the dependencies for the gpuagent Go module and refines the Dependabot configuration for the build and Go ecosystem. The main changes include upgrading several Go dependencies to more recent versions and simplifying how Dependabot tracks and groups updates.

Dependency upgrades:

  • Upgraded google.golang.org/grpc from v1.69.0-dev to v1.83.2 and removed the custom replace directives, ensuring the latest stable release is used.
  • Updated indirect dependencies: golang.org/x/net to v0.58.0, golang.org/x/sys to v0.47.0, golang.org/x/text to v0.41.0, and google.golang.org/genproto/googleapis/rpc to a newer commit.
  • Cleaned up obsolete or redundant replace directives in go.mod for a more streamlined dependency management.

Dependabot configuration improvements:

  • Modified .github/dependabot.yml to remove the Docker ecosystem from the gpuagent-build-and-go group, and added a patterns field to match all Go modules in /sw/nic/gpuagent, simplifying and focusing automated dependency tracking.
  • Ensured that dependency and security labels are retained for Go module updates, maintaining consistency in pull request labeling.

Copilot AI and others added 4 commits September 11, 2026 09:53
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com>
Removed Docker update configuration from Dependabot.
)

* Initial plan

* fix(dependabot): remove duplicate grpc update targets

Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com>

* fix(security): bump grpc to patched v1.83.2

Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com>
@spraveenio
spraveenio requested a lite review from Copilot September 11, 2026 17:39
@spraveenio spraveenio added the ci Workflow related changes label Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Restore standalone Docker Dependabot coverage and update or remove obsolete replacement commands and overrides.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR upgrades gpuagent Go dependencies, including gRPC, and refines Dependabot tracking.

Changes:

  • Updates gRPC and related indirect dependencies.
  • Removes obsolete dependency replacements.
  • Adjusts Dependabot grouping and Go module patterns.
File summaries
File Summary
sw/nic/gpuagent/go.sum Adds checksums for upgraded dependencies.
sw/nic/gpuagent/go.mod Updates dependency versions and replacement directives.
.github/dependabot.yml Refines Go tracking and Dependabot grouping.
Review details

Suppressed comments (1)

sw/nic/gpuagent/go.mod:20

  • With these requirements raised to x/net v0.58.0, x/sys v0.47.0, and x/text v0.41.0, the exact-version replacements still retained below (v0.53, v0.39, and v0.38, plus the older x/net override) no longer apply to the selected module versions. Leaving those obsolete overrides, and the matching make mod commands, makes the dependency graph misleading and defeats the stated replace-directive cleanup; remove or update them together.
	golang.org/x/net v0.58.0 // indirect
	golang.org/x/sys v0.47.0 // indirect
	golang.org/x/text v0.41.0 // indirect
	google.golang.org/genproto/googleapis/rpc v0.0.0-20260526163538-3dc84a4a5aaa // indirect
  • Files reviewed: 2/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/dependabot.yml
Comment thread sw/nic/gpuagent/go.mod
@spraveenio
spraveenio requested a review from sarat-k September 11, 2026 18:20

@sarat-k sarat-k left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarat-k
sarat-k merged commit 4ce6530 into ROCm:main Sep 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Workflow related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants