Automate Go dependency updates and improve security scanning - #95
Merged
Conversation
…on (#6) * Initial plan * Disable gomod Dependabot updates causing unresolved generated package errors Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com> * Restore gomod Dependabot updates and commit generated Go protobuf package Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com> * Apply remaining changes Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com> * Keep generated files out of repo and run full build before Trivy dependency scan Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com>
* Configure Dependabot Go updates Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com> * Fix Dependabot group syntax Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com> * Run Trivy on gpuctl in CI Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: spraveenio <58961022+spraveenio@users.noreply.github.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the build and CI infrastructure, focusing on making the Go version configurable and automating dependency management and security scanning. The most significant changes include parameterizing the Go version in build scripts and Dockerfiles, adding automated workflows for dependency updates and security scans, and fixing file naming inconsistencies.
Build system improvements:
Made the Go version configurable throughout the build system by extracting it from
sw/nic/gpuagent/go.modand passing it as a build argument in both the Makefiles and Dockerfiles. This ensures consistency and simplifies Go version upgrades. [1] [2] [3] [4] [5] [6] [7]Fixed typos in Dockerfile names (
Dokerfile.rhel9andDokerfile.ubu2204renamed toDockerfile.rhel9andDockerfile.ubu2204) for clarity and to prevent build errors. [1] [2] [3]CI/CD and security automation:
Added a Dependabot configuration file to automate dependency update PRs for Docker images, with security and dependencies labels.
Introduced a workflow (
dependabot-cleanup.yml) to automatically delete merged Dependabot branches, keeping the repository clean.Added a Trivy-based dependency scanning workflow to automatically scan Go dependencies for vulnerabilities on PRs and a weekly schedule, and upload results as SARIF for security review.## Motivation
Technical Details
Test Plan
Test Result
Submission Checklist