Game origin rewrite.... Again! - #60
Open
jnackmclain wants to merge 1 commit into
Open
Conversation
all credit to comp for this. This is just the pr RBEnhanced#39 comp made, but applied on top of upstream master, as the branch comp worked from was heavily outdated There are several files with small naming converntion updates, struct updates, and so on. The bulk of the actual feature is in source\SetlistHooks.c a new directory for storing rawfiles now exists in the repo. this holds the folder structure for the new song list milo for xbox 360. This should probably be included in the github action nightly download, but i have not done this here I myself helped by finding the addresses for filling out the ports on the other platforms. go me. I also built and tested locally, which had me see that turning off the game origin setting in the ini didnt do anything, so i added a gate for that in MusicLibraryMatHook to check config.GameOriginIcons == 1. when disabled, it doesnt populate the mats with the textures. which isnt like, the most clean probably, as the mats are still made and the rest of everything still runs, but it doesnt show the icons so it works. I know the history here isnt ideal, being all one commit.... but this is a lot better than the 90 commits in my last pr. Co-Authored-By: ihatecompvir <6479048+ihatecompvir@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all credit to comp for this.
This is just the pr #39 comp made, but applied on top of upstream master, as the branch comp worked from was heavily outdated
There are several files with small naming converntion updates, struct updates, and so on. The bulk of the actual feature is in source\SetlistHooks.c
a new directory for storing rawfiles now exists in the repo. this holds the folder structure for the new song list milo for xbox 360. This should probably be included in the github action nightly download, but i have not done this here
I myself helped by finding the addresses for filling out the ports on the other platforms. go me. I also built and tested locally, which had me see that turning off the game origin setting in the ini didnt do anything, so i added a gate for that in MusicLibraryMatHook to check config.GameOriginIcons == 1. when disabled, it doesnt populate the mats with the textures. which isnt like, the most clean probably, as the mats are still made and the rest of everything still runs, but it doesnt show the icons so it works.
I know the history here isnt ideal, being all one commit.... but this is a lot better than the 90 commits in my last pr.