Fix bugs in GradedSpace constructor + similar of SectorVector - #498
Merged
Conversation
borisdevos
changed the title
GradedSpace constructor + similar of SectorVectorGradedSpace constructor + similar of SectorVector
lkdvos
reviewed
Jul 29, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Good catch! Any chance you can add a test for this to catch this in the future?
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 54 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…into bd/smallbugs
…into bd/smallbugs
Jutho
reviewed
Jul 30, 2026
lkdvos
approved these changes
Jul 30, 2026
Jutho
enabled auto-merge (squash)
July 30, 2026 13:52
lkdvos
disabled auto-merge
July 31, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small bugs I encountered.
Vect[I], sodualwas read as:dual.similars justMethodErrored.