Skip to content

Add test for binary STLs with 'solid' header and fix STLDocument#27

Open
MHebes wants to merge 2 commits into
QuantumConcepts:masterfrom
MHebes:master
Open

Add test for binary STLs with 'solid' header and fix STLDocument#27
MHebes wants to merge 2 commits into
QuantumConcepts:masterfrom
MHebes:master

Conversation

@MHebes

@MHebes MHebes commented Jan 2, 2025

Copy link
Copy Markdown

Fixes #26

@JoshMcCullough ping

@JoshMcCullough JoshMcCullough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good. Couple tweaks...

Comment thread src/STLDocument.cs Outdated
Comment thread src/STLDocument.cs
@MHebes

MHebes commented Jan 2, 2025

Copy link
Copy Markdown
Author

@JoshMcCullough Responding to all your comments at once: It appears that const in C# is only allowed for numbers, Boolean values, strings, or a null reference and is not equivalent to the const keyword in e.g. JavaScript.

It is my understanding that const in C# means "has static storage and can be initialized at compile time" rather than "cannot be changed post initialization". The latter refers to readonly, which is only applicable to class members and not local variables.

@MHebes

MHebes commented Jan 2, 2025

Copy link
Copy Markdown
Author

Happy to adjust whitespace or formatting as you wish, though. I had a lot of trouble getting the pre-push git hook working on windows + git bash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Binary STLs with "solid" prefix better.

2 participants