Skip to content

docs: Add no-defensive-code guideline to AGENTS.md#38

Open
EgeKaraismailogluQC wants to merge 1 commit into
mainfrom
no-defensive-code
Open

docs: Add no-defensive-code guideline to AGENTS.md#38
EgeKaraismailogluQC wants to merge 1 commit into
mainfrom
no-defensive-code

Conversation

@EgeKaraismailogluQC
Copy link
Copy Markdown
Collaborator

@EgeKaraismailogluQC EgeKaraismailogluQC commented May 21, 2026

Motivation

In #34, we noticed that agents tend to be overly defensive when generating code. See this thread.

Changes

Added a directive to AGENTS.md to not be defensive.

@EgeKaraismailogluQC EgeKaraismailogluQC self-assigned this May 21, 2026
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ef4c5e9) to head (71fd430).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          930       930           
=========================================
  Hits           930       930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EgeKaraismailogluQC EgeKaraismailogluQC marked this pull request as ready for review May 21, 2026 13:34
Copilot AI review requested due to automatic review settings May 21, 2026 13:34
@EgeKaraismailogluQC EgeKaraismailogluQC changed the title docs: Add no-defensive-code guideline to AGENTS.md docs: Add no-defensive-code guideline to AGENTS.md May 21, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s AI-agent guidance to discourage adding defensive programming inside internal code paths, aiming to reduce unnecessary guards and boilerplate raised in prior discussion (#34).

Changes:

  • Add an explicit “No defensive code” guideline under Code Standards → Style in AGENTS.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try and observe whether it helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants