Package bluetooth manager and movehub separately - #55
Draft
HaudinFlorence wants to merge 25 commits into
Draft
Conversation
martinRenou
reviewed
Aug 12, 2026
Comment on lines
40
to
48
| "eslint": "jlpm eslint:check --fix", | ||
| "eslint:check": "eslint . --cache --ext .ts,.tsx", | ||
| "install:extension": "jlpm build", | ||
| "lint": "jlpm stylelint && jlpm prettier && jlpm eslint", | ||
| "lint:check": "jlpm stylelint:check && jlpm prettier:check && jlpm eslint:check", | ||
| "prettier": "jlpm prettier:base --write --list-different", | ||
| "prettier:base": "prettier \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"", | ||
| "prettier:check": "jlpm prettier:base --check", | ||
| "stylelint": "jlpm stylelint:check --fix", | ||
| "stylelint:check": "stylelint --cache \"style/**/*.css\"", |
Member
There was a problem hiding this comment.
Let's also use lerna for lint scripts
martinRenou
reviewed
Aug 12, 2026
Member
There was a problem hiding this comment.
Let's keep a license there, and copy it in both underlying packages
| "yjs": "^13.5.0" | ||
| "style-loader": "^3.3.1" | ||
| }, | ||
| "sideEffects": [ |
Member
There was a problem hiding this comment.
The root package.json does not need this I believe.
| "strict": false | ||
| }, | ||
| "include": ["src/**/*"], | ||
| "include": ["packages/bluetooth/src/**/*", "packages/bluetooth-extension/src/**/*"], |
Member
There was a problem hiding this comment.
This is a bit odd, we should probably have a tsconfig.json in the underlying packages
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
2 times, most recently
from
August 12, 2026 13:52
9868a1c to
f6c3c57
Compare
…nto account. Restore and update global LICENSE file and add similar files in the packages.
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
2 times, most recently
from
August 13, 2026 10:09
8903cdf to
64602ef
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
from
August 13, 2026 12:35
64602ef to
e6cf3bc
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
2 times, most recently
from
August 13, 2026 15:09
873f077 to
afbf1aa
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
from
August 14, 2026 09:09
afbf1aa to
4e40520
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
6 times, most recently
from
August 17, 2026 08:43
aff6503 to
125033a
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
from
August 17, 2026 13:46
9a0ec9b to
cb1f605
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
4 times, most recently
from
August 17, 2026 15:09
ecfaa35 to
a0ca25f
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
from
August 17, 2026 16:45
a0ca25f to
b302c92
Compare
Remove playwright related action in build.yml.
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
from
August 17, 2026 21:00
cc3053b to
cee54f3
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
6 times, most recently
from
August 18, 2026 11:44
6de37f8 to
fdef479
Compare
martinRenou
requested changes
Aug 18, 2026
| "**/__tests__", | ||
| "ui-tests" | ||
| ], | ||
| "eslintConfig": { |
Member
There was a problem hiding this comment.
Let's move those rules on the top level package.json?
| "webpack": "5.109.2", | ||
| "yjs": "^13.5.0" | ||
| }, | ||
| "styleModule": "style/index.js", |
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
6 times, most recently
from
August 18, 2026 13:30
fc1346f to
4b6709e
Compare
HaudinFlorence
force-pushed
the
package-bluetooth-manager-and-movehub-separately
branch
from
August 18, 2026 13:43
4b6709e to
81bbe58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.