Neelay/fix post inference#617
Open
neelay893 wants to merge 2 commits into
Open
Conversation
neelay893
requested review from
Roger-luo and
kaihsin
and removed request for
kaihsin
March 4, 2026 20:08
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
this was intentional so you have to use |
Contributor
Author
|
Then maybe we need to change how rewrite rules are being registered as post-inference (as is the case with vmath desugar https://github.com/QuEraComputing/kirin/blob/main/src/kirin/dialects/vmath/rewrites/desugar.py#L61)? I first noticed this when an |
Roger-luo
added
area: compiler pass
Roger-luo
added
the
priority: low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post_inference pass (set of rewrite rules that runs after
TypeInfer) was configured such that the registered rewrite rules would not actually walk the IR; this PR changes (rule.rewrite(mt.code).join(result)) toWalk(rule).rewrite(mt.code).join(result)).