Skip to content

feat: implement stateful Q10 device simulator and integration tests#869

Open
allenporter wants to merge 2 commits into
Python-roborock:mainfrom
allenporter:feat-b01-testing-support
Open

feat: implement stateful Q10 device simulator and integration tests#869
allenporter wants to merge 2 commits into
Python-roborock:mainfrom
allenporter:feat-b01-testing-support

Conversation

@allenporter

@allenporter allenporter commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Introduces Q10VacuumSimulator for stateful simulation of Roborock Q10 (B01 ss07) devices. Implements streaming updates over FakeChannel, registers it in the patcher environment, and adds a full end-to-end integration test case.

@Lash-L Lash-L requested a review from Copilot July 8, 2026 10:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@allenporter allenporter force-pushed the feat-b01-testing-support branch from f0dccc2 to fb6e1ae Compare July 8, 2026 22:54
@allenporter

Copy link
Copy Markdown
Contributor Author

Since Copilot hit its quota limit, I asked Antigravity (Google DeepMind's autonomous coding assistant) to perform the code review of this PR instead.

We reviewed the changes and addressed the following recommendations:

  1. Docstring Clarification: Updated the comment on publish_handler in roborock/testing/channel.py to explicitly note that it must be asynchronous.
  2. TODO Warning Refinement: Updated the TODO warnings in roborock/testing/cloud.py to remove Q10 from the list of unsupported simulators since it is now fully supported.

The code has been amended, all tests pass successfully, and the PR is ready for human review!

@allenporter allenporter force-pushed the feat-b01-testing-support branch from fb6e1ae to d2fa621 Compare July 11, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants