DOM: appendChild(DOMDocument) raises Hierarchy Request Error (#22698)#22800
Merged
Conversation
Accept DOMDocument as a typed DOMNode argument, then reject with DOMException message/code 3 (php-src ext/dom/node.c) instead of TypeError. Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate docs/bootstrap-inventory.md after taking master for the conflicted generated file. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMElement/DOMNode/DOMDocument/DOMDocumentFragment::appendChild()type gates now accept any registryDOMNode, includingDOMDocument(php-src stub).VmDom::appendChildrejects non-tree children withDOMExceptionHierarchy Request Error / code 3 viaDomExceptionConstants::raiseHierarchyRequest()(php-srcext/dom/node.c).Closes #22698
php-src reference
ext/dom/node.c—dom_node_append_childhierarchy checkext/dom/php_dom.c—HIERARCHY_REQUEST_ERRPHP implementation
ext/dom/ElementAppendChild.php,NodeAppendChild.php,DocumentAppendChild.php,FragmentAppendChild.phpext/dom/VmDom.php,ext/dom/DomExceptionConstants.phpTest plan
php bin/vm.php test/repro/issue_22698_appendchild_document_hierarchy.phpphp bin/jit.php test/repro/issue_22698_appendchild_document_hierarchy.php./script/phpunit.sh --filter dom_appendchild_document_hierarchy(VM+JIT green)php script/bootstrap-inventory.php --check→ OK 6508/6508Trust preflight (host)
north-star5-fast: red on master — gen-0 manifest/driver mismatch (Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713); not caused by this DOM-only changeNote
dom_node_appendchild_ancestor_hierarchy(#19753) currently shows emptyinsertBefore/replaceChildexception payloads on this host for both master and this branch (pre-existing); out of scope for #22698.Made with Cursor