DOM: insertBefore($n,$n) throws Error previous sibling (#22686)#22769
Merged
Conversation
Match php-src ext/dom/node.c: same-node insertBefore raises Error before detach (not DOMException NOT_FOUND). Wire user-script AOT insertBefore through DomCreateElementJitHelper like replaceChild. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Cleanup bot: deleted leftover remote branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMNode::insertBefore($n, $n)inVmDomso same-node insert raisesError: Cannot add newnode as the previous sibling of refnodebefore detach (php-srcext/dom/node.c), instead ofDOMException: Not found error.insertBeforeviaJitDomInsertBefore+DomCreateElementJitHelper(same pattern asreplaceChild).Closes #22686
php-src reference
ext/dom/node.c—dom_node_insert_before/ libxmlxmlAddPrevSiblingfailure whennew == refVerification
Test plan
dom_node_insertbefore_self_ref.phptMade with Cursor