Stdlib: MessageFormatter invalid pattern → null + IntlException (#22577) - #22766
Merged
Conversation
Reject unmatched MessageFormat braces at create/construct like php-src (umsg_open / U_UNMATCHED_BRACES), return null from create/msgfmt_create, throw IntlException from __construct, and idle intl_get_error_message as U_ZERO_ERROR. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create/__construct/setPattern(php-srcext/intl/msgformat/msgformat_create.c, ICUU_UNMATCHED_BRACES).MessageFormatter::create/msgfmt_createreturnnull(not false);__constructthrowsIntlExceptionwith the Zend message.intl_get_error_message()isU_ZERO_ERRORwhen code is 0 (php-srcintl_error.c).IntlExceptionvia ThrowableManifest (gated on host intl) + VM catch bridge; PHP-in-PHP only.Closes #22577
php-src reference
ext/intl/msgformat/msgformat_create.cext/intl/intl_error.cTest plan
php8.2-intlinstalled in Docker):vendor/bin/phpunit --filter 'msgfmt_create_unmatched_braces|intl_error_functions'(VM + JIT for new case)IntlModuleTest::test_messageformatter_invalid_pattern_create_null_construct_throwsphp script/bootstrap-inventory.php --check→ OK 6506/6506php script/check-selfhost-spine-coverage-sync.php→ OKPillar 1 note (pre-claim)
north-star5-fastred on master (gen-0 mismatch Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713 / Bootstrap: unblock gen-0 spine refresh — docblock, ghost require, exclusive launcher (#22642) #22717) — not touched by this PR.Made with Cursor