Stdlib: FFI\CData ArrayAccess for C arrays (#22761) - #22763
Merged
Conversation
Enable int[N] index read/write via offsetGet/offsetSet on the host CData bridge. offsetExists/Unset match Zend’s “Cannot use object as array”. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FFI\CDataC-array$a[$i]read/write via host bridge + ArrayAccess methods inext/ffi/VmFFI.php.offsetExists/offsetUnsetthrow Zend’sCannot use object of type FFI\CData as array(php-src uses custom handlers, not ArrayAccess; VM needs the interface for dim ops).Test plan
php bin/vm.php test/repro/issue_22761_ffi_cdata_array.phpmatches Zend (1 2 3/mid=99)phpunit --filter ffi_cdata_array_access|ffi_memcpy|ffi_new_castOK--checkOKMade with Cursor