[cmake] Windows check ARM64/WIN64 symbols#51
Merged
Conversation
use check_symbol_exists to be able to test for Arch specific symbols for x64 and arm64 arch types.
opdenkamp
added a commit
to Pulse-Eight/libcec
that referenced
this pull request
Jul 16, 2026
…fix (platform #51) pulls in platform 2ff8f0e (merge of Pulse-Eight/platform#51), which replaces the never-defined ${WIN64}/${_M_ARM64} cmake variables with check_symbol_exists(_AMD64_/_ARM64_ ...). this makes p8-platform define _USE_32BIT_TIME_T on x86 (matching libcec, which already does) and strip the /arch:SSE2 flag on arm64 that MSVC warns about. verified on real MSVC: WIN64=1 on x64, ARM64=1 on arm64, both empty on x86.
Contributor
|
Merged, thanks @fuzzard. Verified the detection on real MSVC (VS2022 17.13, cmake 4.3) across every target arch before merging:
Confirms this fixes two real problems the old
x64 behaviour is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar issues as Pulse-Eight/libcec#675
the
_M_ARM64symbol isnt available always at cmake configure time.Instead use check_symbol_exists to be able to test for Arch specific symbols for x64 and arm64 arch types correctly always.
Also, add removal of /arch:SSE2 flag for arm64 arch type as well to remove warnings.