feat(ledger-core): wire up ufo-types — Stereotyped for ArtifactKind - #145
Open
elasticdotventures wants to merge 1 commit into
Open
feat(ledger-core): wire up ufo-types — Stereotyped for ArtifactKind#145elasticdotventures wants to merge 1 commit into
elasticdotventures wants to merge 1 commit into
Conversation
Realizes the architecture ufo-types' own module docs already describe: ufo-types (traits) -> ledger-core (domain impls) -> MCP actions. This was previously documented but unimplemented — ledger-core had zero reference to ufo-types despite being its intended first real consumer. Implements Stereotyped for ArtifactKind, classifying every existing ontology.rs artifact kind per Guizzardi's UFO (Kind/SubKind/Relator/Mode) so a future record_is_a(subject, ufo_stereotype) evidence-layer call has real ontological labels to emit, instead of ledger-core reinventing its own classification scheme. Depends on ufo-types v0.10.1 from its new standalone repo (github.com/PromptExecution/ufo-types), pinned via git tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ufo-types' own module docs describe the intended architecture asufo-types (traits) -> ledger-core (domain impls) -> MCP actions, butledger-corehad zero actual reference toufo-types— this PR realizes it.ufo-typeswas recently extracted fromelasticdotventures/_b00t_into its own standalone repo: https://github.com/PromptExecution/ufo-types (git history preserved). This PR adds it as a real dependency ofledger-core, pinned to thev0.10.1tag.Stereotyped for ArtifactKindincrates/ledger-core/src/ontology.rs, classifying every existingArtifactKindvariant according to Guizzardi's Unified Foundational Ontology:Document,Account,Institution,Transaction,TaxCategory,XeroContact,ModelJob,WorkbookRowXeroBankAccount(⊆ Account),XeroInvoice(⊆ Document),DocumentChunk(⊆ Document)EvidenceReference,ModelProposal,AuditEventWorkflowTag,ValidationIssue,ClassificationOutcomerecord_is_a(subject, ufo_stereotype)evidence-layer call (NS-9, perufo_types::stereotypedocs) real ontological labels to emit forledger-coreartifacts, instead ofledger-coreneeding to invent its own classification scheme from scratch.Test plan
cargo build -p ledger-core— clean, correctly resolvesufo-typesfrom the new repo (Compiling ufo-types v0.10.1 (https://github.com/PromptExecution/ufo-types.git?tag=v0.10.1#2c919f24))cargo test -p ledger-core ontology— all 6 ontology tests pass, including the 2 new ones (artifact_kind_ufo_stereotype_labels,artifact_kind_ufo_stereotype_covers_every_variant)