Repository navigation
feat: one page frame, themed controls and create buttons in one place across Strata - #98
Merged
Merged
Conversation
… across Strata Every page now uses the shared Page frame with its actions in the header, every create action opens a dialog from a button on the right, and every select, date and time field uses the themed graphite-ui 0.4.0 controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A design pass over the whole app, following review feedback: the sidebar floated at the bottom of the page, controls were native and unthemed, create buttons sat in a different place on every screen, and layouts differed page to page.
Dependency:
@project-graphite/uigoes from 0.3.0 to 0.4.0 (our own package; Project-Graphite/graphite-ui#13). It adds themedSelect,DatePicker,TimePicker,ColorSwatches,SuggestField, calm skeleton timing (useSettled), framed list rows, and moves the footer into the content column, so the sticky sidebar no longer floats.One layout
components/Page.tsx:Page(title, description, header actions, one width),HeaderButton,Toolbar(filters on the left, actions on the right) andSection(replacesSettingsSection). Every app page uses it: Home, Today, Agenda, Calendars, Event, Pages, Boards, Bookmarks, Journal, Recurring, Tidy, Inbox, Invitations, Trash, Menu, Spaces, Settings and Site settings.Toolbaron the right.panel-rowsandpanel-roweverywhere, with the same padding.Create from one place, in a dialog
Themed controls everywhere
<select>, date, time or<datalist>remain. Every picker uses graphite-ui, including those in database cells, widget settings, statement import, splits and date polls.choices.ts).spaceOptions,roleOptionsandcolorOptionsinspaces.tsx.Settings
Smaller fixes
·and▦, with chevron and plus icons in the tree.useResource.Tests
test/controls.ts(choose,chooseFromMenu,pickDay) drive the themed controls.·placeholder glyph this change removes.tsc -b, oxlint and the frontend build.