Repository navigation
feat: comment on a block of a page - #85
Merged
Merged
Conversation
AmrMsCLL
force-pushed
the
feat/block-comments
branch
from
October 9, 2026 11:29
a5c8c0f to
570acbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes step N6. Contains a migration — waiting for Amr's approval before merging.
Migration
20261009000000_comment_blocks:A nullable column with no default, so existing comments are unchanged (they stay page comments).
What it does
@tiptap/extension-unique-id, approved; ids are not generated for remote changes, so collaborators don't race).blockId. Replies stay in the thread and never carry a block id.Tests: new block comment case in
test/notes.spec.tsx,test/block-menu.spec.tsx, lint and type check.test/integration/note-comments.spec.tscovers saving block ids and keeping replies in the thread (CI). Not checked in the browser: that needs the migration applied to the local database, which also waits for approval.