Repository navigation
feat: embed boards in pages with a live preview - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boards step B2.
/boardin the page editor creates a board inside the page and embeds it. The embed shows a preview of the drawing (Excalidraw'sexportToSvg, loaded only when a preview is on screen, images included) and an Open board link. Embedded boards count as links, so the board lists the page under Linked from.GET /notes/:id/boardreturns a board's current elements from storage (boards only; pages get 404).Reset the canvas(which would wipe a shared board) are gone.components/board-files.ts, shared by the canvas and the preview.Checked in the browser (local stack):
/boardadds an embed; after drawing on the board the page shows the preview; an image dropped on the board uploads through/spaces/:id/files, is stored on the board by file id and appears in the preview; the board menu shows only the items above.Tests:
test/block-menu.spec.tsx(the Board entry),test/notes.spec.tsx,test/document-text.spec.ts(embeds become links);test/integration/notes.spec.tscovers the board endpoint (CI).