Repository navigation
feat: total subscriptions in a home currency at ECB rates and suggest known services - #40
Merged
Merged
Conversation
AmrMsCLL
force-pushed
the
feat/weather-news-widgets
branch
from
October 5, 2026 19:02
b4dfe42 to
46910c1
Compare
AmrMsCLL
force-pushed
the
feat/exchange-rates
branch
from
October 5, 2026 19:03
d7c5ae4 to
8459ce4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The two Recurring decisions from
.claude/.Plans/as2026-10-02-strata-phase-6-recurring-design.md, which Amr approved. Stacked on #39. No new dependency.eurofxref-daily.xml) when the stored ones are over 12 hours old, and keeps them inexchange_rates;GET /exchange-rateslists the date and the currencies.users.home_currencyis new, set from Settings → Profile, with "None, keep each currency separate" as the default;GET /subscriptions/summaryaddshomewith the converted monthly and yearly totals, the rates' date, and any currencies with no rate, which are left out rather than guessed;Migration (runs on deploy)
20261005000000_exchange_rates:It only adds a nullable column and a new table.
Verification
Lint, the server and frontend builds, and
tsc --noEmitpass.The new
test/exchange-rates.spec.tscovers parsing the ECB file, refusing a page with no rates, and converting EUR, USD, GBP and JPY, with a missing currency givingnull.The new
test/integration/exchange-rates.spec.tsstubs the ECB. It covers:It and
subscriptions.spec.tspass against Postgres on the local stack.test/subscriptions.spec.tsxadds cases for typing "netflix", which fills the category and cancel link, and for the combined total.settings.spec.tsxpasses.Running the integration spec locally replaces the dev database's rates with the stub rates until the next refresh, 12 hours later. CI's database is thrown away after each run.