Warn when a semantic map query has no coordinate printout#918
Draft
JeroenDeDauw wants to merge 1 commit into
Draft
Warn when a semantic map query has no coordinate printout#918JeroenDeDauw wants to merge 1 commit into
JeroenDeDauw wants to merge 1 commit into
Conversation
For #917 When an #ask query with a map format returns results but none of the queried properties can provide coordinates, the map printer rendered nothing (the empty "default" parameter), leaving no hint about why the map is missing. This commonly happens when a property is unintentionally typed Text, for instance via a stale vocabulary import mapping schema:geo to Type:Text (as shipped by Semantic MediaWiki before version 5.0). The printer now adds a query error, rendered through Semantic MediaWiki's standard warning mechanism, explaining that none of the queried properties has the "Geographic coordinates" type. The warning is suppressed for queries that get their markers elsewhere: a fully configured ajaxcoordproperty/ajaxquery pair, geojson, or GoogleMaps3's kml/gkml, and for record printouts (records can contain coordinate fields). Queries that do have a coordinate printout but no values keep the existing silent behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JeroenDeDauw
force-pushed
the
warn-about-missing-coordinate-printout
branch
from
cf99236 to
4981e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #917
When an
#askquery with a map format returns results but none of the queried properties can provide coordinates, the map printer rendered nothing (the emptydefaultparameter), leaving no hint about why the map is missing. This commonly happens when a property is unintentionally typed Text, for instance via a stale vocabulary import mappingschema:geotoType:Text(as shipped by Semantic MediaWiki before version 5.0).The printer now adds a query error, rendered through Semantic MediaWiki's standard warning mechanism (the inline warning marker with the message in its tooltip), explaining that none of the queried properties has the "Geographic coordinates" type. The warning is suppressed for queries that get their markers elsewhere: via
ajaxcoordproperty/ajaxquery, via thegeojsonparameter, or via a record printout (records can contain coordinate fields). Queries that do have a coordinate printout but no values keep the existing silent behavior.Written by Claude Code, Fable 5. Result of an investigation session with @JeroenDeDauw. Context: the Maps codebase, Semantic MediaWiki 6/7 sources and release notes, and live debugging of the issue reporter's public wiki pages.