Send Client Information (settings) packet during configuration phase

[AChompSitsIn]

On 1.20.2+ the vanilla client sends Client Information (settings) during the
configuration phase; node-minecraft-protocol never does. Servers that gate
finish_configuration on it (e.g. Hypixel) never advance and drop the client
with socketClosed right after login_acknowledged — so bots can't join on
1.20.2–1.21.x.

Fix: write settings immediately after the CONFIGURATION state flip in
enterConfigState (inside the existing hasConfigurationState branch, so 1.20.2+
only). particleStatus (1.21.2+) is omitted so one payload serializes on every
config-phase version.

Supersedes #1402, which wrote the packet before the state flip (still login
state → serialization error → CI failed on exactly 1.20.2–1.21.4).

Tested: lint, serverTest (319), packet/cyclePacket (5983), and real-server
clientTest on 1.21.4 + 1.21.9 all pass. mineflayer joins Hypixel 1.21.9 with this
change; socketClosed without.

Fixes PrismarineJS/mineflayer#3623

[extremeheat]

mineflayer on login does send its own settings, so sending them inside nmp can conflict with mineflayer's own settings.

How does this PR handle that?

[extremeheat]

These should be configurable parameters

[AChompSitsIn]

Good points, thanks.

On the conflict with mineflayer's settings: there isn't one. This mirrors the vanilla client, which sends Client Information in both the configuration and play phases. The config-phase send only exists to unblock servers (like Hypixel) that won't send finish_configuration until they receive it. mineflayer's existing play-state send (bot._client.on('login', ...)) still runs afterward and stays authoritative for the user's bot.settings; last write wins, and the config-phase values don't affect gameplay (no world/chunks exist yet during configuration). So mineflayer users keep their configured settings; this just lets the handshake complete on strict servers. Raw node-minecraft-protocol clients (no play-phase send) now get sane defaults, which is the actual fix.

On configurability: done. The values now come from a clientSettings option (documented in docs/API.md), each field defaulting to a vanilla-safe value:

createClient({
  // ...
  clientSettings: { viewDistance: 4, locale: 'en_gb', mainHand: 0 } // any subset
})

If you'd prefer, mineflayer can pass its bot.settings-derived values through as clientSettings in a follow-up so the config-phase and play-phase sends are byte-identical, but that's optional since the play-phase send already applies them.

Tested: lint, serverTest (319), packetTest/cyclePacketTest (5983), and real vanilla-server clientTest on 1.21.4 + 1.21.9 all pass.

[extremeheat]

Right, if it's sent during PLAY phase login packet again (like in mineflayer) and overrides I guess ok to send interim values inside nmp. I was thinking these should be delegated to user responsibility but if you can configure it inside the client construction parameters, it looks good to me

Thanks