chore: update Flutter PopScope callback#446
Merged
Merged
Conversation
|
Reviews (1): Last reviewed commit: "chore: update Flutter PopScope callback" | Re-trigger Greptile |
5 tasks
…pop-scope # Conflicts: # api/posthog_flutter.api.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Flutter 3.27 is now the minimum supported version, so survey UI code can use the newer PopScope callback instead of the deprecated API. This also removes a couple of stale TODO comments.
💚 How did you test it?
make checkApiDartcd posthog_flutter && dart analyze lib/posthog_flutter_web.dart lib/src/posthog_config.dart lib/src/surveys/widgets/survey_bottom_sheet.dart📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Updated the survey bottom sheet to use
onPopInvokedWithResult, which is available with the current Flutter minimum, and removed stale TODO notes in the changed files. The branch was merged with the latestmain; the public API snapshot conflict was resolved by keepingmain's version-independent snapshot format.