Repository navigation
fix: StaticFileManager::registerDirectory() + PSR-12 (release blocker) - #30
Merged
Merged
Conversation
- Application::staticFiles() passed $this to StaticFileManager::registerDirectory(), but the method was decoupled from core (core-routing) and now expects (routePrefix, physicalPath, options). Removes the stale $this argument (fixes PHPStan level 9 errors). - Auto-fix PSR-12 multi-line function call violations in 4 test files.
🚀 Release Readiness Report - PivotPHP Core v2.2.0✅ All Checks Passed!
📦 Ready for PublicationThe project is ready to be tagged and released! Next Steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Corrige os 2 erros que estavam reprovando a validação de release:
Application::staticFiles()chamavaStaticFileManager::registerDirectory($routePrefix, $physicalPath, $this, $options)— mas ométodo foi desacoplado do core (
pivotphp/core-routing) e agora espera($routePrefix, $physicalPath, $options). Remove o argumento$thisobsoleto.Mudanças
src/Core/Application.php:staticFiles()corrigido.tests/Core/ContainerTest.php,tests/Middleware/SimpleLoadShedderTest.php,tests/Middleware/Performance/RateLimitMiddlewareTest.php,tests/Support/StrTest.php:formatação PSR-12.
Como testar
Versionamento (SemVer)
PATCH →
2.2.1.Instruções de merge
Squash and mergeparamain.