Fix recursive input event loop causing stack overflow in ColorPickerSlider - #2288
Open
Rakosn1cek wants to merge 2 commits into
Open
Fix recursive input event loop causing stack overflow in ColorPickerSlider#2288Rakosn1cek wants to merge 2 commits into
Rakosn1cek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Interacting with the colour picker wheel or slider resulted in an immediate crash due to stack overflow.
When updating colours programmatically,
ColorPickerSlider.ColorcallsGtk.Entry.SetText(). Under GTK4, setting text fires theOnInputFieldChangedsignal even when the entry is not being actively focused or edited by the user. This re-invokedOnColorChanged, updatingColorPickerDialog, which then assigned back toColorin an infinite recursion.This patch introduces a
suppress_input_eventsguard to ignore input change notifications during programmatic text updates in both theColorsetter and slider drag handlers, preventing the feedback loop.Checklist