Skip to content

ci(prow): migrate tikv/tikv release-6.5 jobs to target jenkins - #5153

Merged
wuhuizuo merged 1 commit into
mainfrom
phase4/tikv-tikv-release-6.5
Sep 8, 2026
Merged

ci(prow): migrate tikv/tikv release-6.5 jobs to target jenkins#5153
wuhuizuo merged 1 commit into
mainfrom
phase4/tikv-tikv-release-6.5

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Part of #4964.

Summary

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/tikv/tikv/release-6.5-presubmits.yaml so they are scheduled on the to Jenkins.

Part of #4947 / #4942

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR updates the Prow job configurations for the tikv/tikv repository on the release-6.5 branch by flipping the labels.master value from "1" to "0" for Jenkins agent jobs. This effectively migrates those jobs from the old Jenkins instance to the target Jenkins environment. The changes are minimal, focused, and correctly applied to relevant job definitions. Overall, the PR is straightforward and appears correct for its intended purpose.


Code Improvements

  • Clarify the master label semantics
    File: prow-jobs/tikv/tikv/release-6.5-presubmits.yaml (lines ~11 and ~22)
    The label key master with values "1" or "0" is not self-explanatory. Consider adding a comment explaining what the label controls (e.g., routing to old or new Jenkins). This will help future maintainers understand the impact of toggling this flag. For example:

    labels:
      # master: "0" schedules this job on the target Jenkins instance; "1" routes to the legacy Jenkins.
      master: "0"
  • Consistent comment style and clarity
    The comment decorate: false # need add this. is slightly unclear and has a grammar issue. Consider rephrasing to something like:

    decorate: false # Required for Jenkins agent jobs

Best Practices

  • Testing / Validation
    Since this change affects CI job routing, it’s recommended to:

    • Ensure that these jobs run successfully on the target Jenkins after this migration before fully deprecating the old Jenkins jobs.
    • Add a note in the PR description or commit message about any manual validation or planned monitoring.
  • Documentation update
    If there is any central documentation about CI job routing or how to configure labels.master, it should be updated or linked in the PR description for completeness.


No critical issues found. The PR is concise and makes the intended configuration change correctly. Adding a bit more context in comments and ensuring validation will further improve maintainability and confidence.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Sep 4, 2026
@ti-chi-bot

ti-chi-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

  • tikv/tikv/release-6.5/pull_unit_test
    • status: skipped
  • tikv/tikv/release-6.5/pull_integration_test
    • status: skipped

Summary: success=0 submitted=0 failed=0 infra-fail=0 skipped=2 dry-run=0 total=2

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/tikv/tikv/release-6.5-presubmits.yaml so
they are scheduled on the to Jenkins.

Part of #4964
@wuhuizuo
wuhuizuo force-pushed the phase4/tikv-tikv-release-6.5 branch from 8a75872 to f2e479d Compare September 7, 2026 03:18

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR modifies the prow job definitions for the tikv/tikv release-6.5 branch by changing the labels.master flag from "1" to "0" for jenkins-agent jobs in release-6.5-presubmits.yaml. This effectively migrates the scheduling of these jobs from the old Jenkins instance to the target Jenkins, as part of ongoing CI infrastructure migration efforts. The changes are minimal and focused, making the intent clear and likely low-risk.


Code Improvements

  • prow-jobs/tikv/tikv/release-6.5-presubmits.yaml lines 11-15, 22-26
    The label master: "0" is used to switch Jenkins agents, but the meaning of the master label value is not self-evident. Consider adding a clarifying comment near the label to explain why "0" means scheduling on the target Jenkins (e.g., # master: "0" schedules on target Jenkins, "1" on legacy Jenkins). This will help future maintainers understand the context.

    Suggested addition:

    labels:
      master: "0" # "0" means schedule on target Jenkins; flip from "1" to migrate agents
  • Error Handling / Consistency
    The decorate field is set to false with a comment # need add this.. This comment is unclear and incomplete. If it means the field was missing before and now added, clarify it or remove the comment. Also, verify if decorate: false is the desired setting for all migrated jobs, as this affects job log decoration and reporting.


Best Practices

  • Documentation Needs (prow-jobs/tikv/tikv/release-6.5-presubmits.yaml)
    There is no high-level comment describing the purpose of this file or the significance of the labels.master flag. Consider adding a brief header comment explaining that this file defines presubmit jobs for release-6.5 and that the master label controls agent scheduling for Jenkins migration.

  • Testing Coverage Gaps
    Since this change affects CI job scheduling, ensure that after the migration the jobs actually run on the target Jenkins and that logs/reports are generated correctly. If not already present, add a checklist or link to a test plan in the PR description or commit message.


No critical issues were found given the limited scope of the change. The PR is straightforward and low-risk but would benefit from improved inline documentation for maintainability and clarity.

@wuhuizuo

wuhuizuo commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@wuhuizuo

wuhuizuo commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 8, 2026
@wuhuizuo
wuhuizuo merged commit 1e5dcb0 into main Sep 8, 2026
8 of 9 checks passed
@wuhuizuo
wuhuizuo deleted the phase4/tikv-tikv-release-6.5 branch September 8, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants