Skip to content

docs(P-010): restructure Own.Types around the five-pillar taxonomy - #187

Closed
PhysShell wants to merge 1 commit into
mainfrom
claude/own-types-documentation-1x4iut
Closed

PhysShell wants to merge 1 commit into
mainfrom
claude/own-types-documentation-1x4iut

Conversation

@PhysShell

Copy link
Copy Markdown
Owner

Что и зачем

Перестроил docs/proposals/P-010-type-disciplines.md (Own.Types) вокруг явной таксономии из пяти столпов: semantic primitives, algebraic domain modeling, state/lifetime discipline, tooling, future. Добавил ранее недокументированные пункты (discriminated unions, exhaustive matching, Option, Result, strongly typed IDs, ValueTask/single-use), а typestate/ownership-пункты, уже покрытые P-004/005/006/007, оформил как перекрёстные ссылки, а не дублирование.

Тип изменения

  • docs — документация

Как проверено

  • python tests/run_tests.py
  • ruff check . и mypy
  • селфтесты затронутых скриптов (python scripts/<...>.py --selftest)

Изменение только в docs/proposals/ (design-proposal, не spec/), кода не касается — прогонять тесты/линт не требовалось. Проверено вручную: сбалансированность markdown-код-блоков, отсутствие противоречий с существующими P-004/005/006/007/017 и с префиксами диагностик (DI/EFF/OBL) в ownlang/diagnostics.py.

Связанные issue

Нет связанных issue.

Чеклист

  • изменение покрыто тестом/селфтестом (или объяснено, почему нет) — proposal-документ не входит в тестовый контур spec/, см. выше
  • README/docs обновлены при необходимости — это и есть doc-обновление
  • коммиты в conventional-commit стиле (feat:, fix:, docs: …)

Generated by Claude Code

Reorganize the type-disciplines proposal under semantic primitives,
algebraic domain modeling, state/lifetime discipline, tooling, and
future — adding discriminated unions/exhaustive matching/Option/Result
(previously undocumented anywhere in the repo), strongly typed IDs,
ValueTask/single-use constraints, and an elaborated tooling section
(source generators, code fixes, generated docs, OwnIR facts). Existing
typestate/ownership items are cross-referenced to P-004/005/006/007
instead of duplicated, and a diagnostic-prefix open question (`TYP0xx`
vs `[type: …]` tag) is recorded against the DI/EFF/OBL precedent.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019ChcHzqtYRaVGiHmL2dCQ8
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@PhysShell, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ca3dd098-2b76-49b4-afd8-6adf41bbbba6

📥 Commits

Reviewing files that changed from the base of the PR and between 5ea68da and 64f4e67.

📒 Files selected for processing (1)
  • docs/proposals/P-010-type-disciplines.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/own-types-documentation-1x4iut

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Консолидировано в #190 (реструктуризация P-010 вошла; исправлено инвертированное утверждение об источнике истины OWN-кодов — это ownlang/diagnostics.py, а spec/Diagnostics.md производный). Закрываю в пользу единого PR.


Generated by Claude Code

@PhysShell PhysShell closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants