docs(proposals): P-026 unneeded-dependency profile (Own.Lean) - #180
docs(proposals): P-026 unneeded-dependency profile (Own.Lean)#180PhysShell wants to merge 2 commits into
Conversation
Evidence-only "you don't need this abstraction" checks, inspired by the you-dont-need/You-Dont-Need meta-list but scoped away from opinion: each finding names a call site with zero customization evidence (a trivial AutoMapper 1:1 profile, a MediatR handler with one impl and no pipeline behaviours) rather than judging a library's presence. Report-only, never a build gate; bounded against P-021 (async elision already owned by ASYNC040) and P-023 (Own.Arch gates forbidden structure, this flags redundant structure). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NNLSE5z4V92RwdHHF1mW45
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01ff4b8291
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… reuse Codex review on #180 caught it: the extractor's DiTypeName collapses IRequestHandler<Foo,Bar> to the bare IRequestHandler identifier, so the existing P-006 services[] graph can't distinguish per-request-type implementation counts once a project has more than one MediatR handler. Correct the MVP scope and sketch to require a small additive extractor change that preserves closed generic arguments for MediatR marker interfaces, instead of claiming YDN002 rides the graph as-is. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NNLSE5z4V92RwdHHF1mW45
|
Консолидировано в #190 (перенумеровано P-026 → P-028-unneeded-dependency-profile из-за коллизии номеров). Закрываю в пользу единого PR. Generated by Claude Code |
2 participants
Что и зачем
Добавляет P-026 — предложение по профилю проверок «you don't need this abstraction»
(
Own.Lean), вдохновлённое мета-спискомyou-dont-need/You-Dont-Need, нонамеренно ограниченное доказуемыми находками на конкретном call site (тривиальный
1:1
AutoMapper-профиль,MediatR-хэндлер с единственной реализацией и безpipeline behaviours), а не мнением о библиотеке как таковой.
Тип изменения
Как проверено
Только markdown-документация (новый
docs/proposals/P-026-...md+ записи виндексах
docs/proposals/README.mdиdocs/ROADMAP.md), кода не затронуто —тестов/линтеров не требуется.
Связанные issue
Нет.
Чеклист
docs/proposals/README.mdиdocs/ROADMAP.mdобновленыfeat:,fix:,docs:…)Generated by Claude Code