docs: P-023 architecture guard proposal (Own.Arch) - #171
Conversation
Intent model (architecture.rules.yaml) vs actual dependency graph, with a baseline ratchet: only new violations fail the build. Fingerprint policy, CI decision table, SARIF/markdown reporting, tiered ARCH### diagnostics (deterministic / heuristic / report-only), explicit non-goals (no C4 as source of truth, no runtime telemetry, no dead-code gates). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvV8eSjV4R1Qi1vGw6fDg2
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a new architecture proposal document, P-023, defining the "Own.Arch" architecture guard concept—an architecture-drift gate that fails PRs only on new dependency violations while baselining pre-existing ones—and registers it in the proposals index. ChangesArchitecture Guard Proposal
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Generated by Claude Code |
|
✅ Action performedReview finished.
|
PR #171 (architecture guard, Own.Arch) merged to main first and took P-023; the security audit profile proposal moves to the next free number. Index row re-linked accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113xowoaqfUnPEXxxi15Gpm
…wn scanner engine (#169) Records the design-discussion verdict on the Own.SecurityChecks idea: do not build a custom security scanner engine — it duplicates Nuclei/ testssl.sh/ZAP/Trivy and violates the audit charter in Plan.md (orchestrator-not-analyzer, no regex heuristics, take ready tools). Instead: a security profile for the existing audit fleet — tool-run manifests + thin raw→SARIF adapters (v0.1), a typed .NET config analyzer as the only own-code niche (v0.2), cross-tool correlation reusing the oracle scorer (v0.3). Non-goals section pins the rejected engine. Renumbered P-023 -> P-024 after #171 took P-023 (architecture guard). Review fixes: MD040 fence label (CodeRabbit), --include-transitive on the NuGet vulnerability scan (Codex).
Что и зачем
Новый proposal
P-023— architecture guard (Own.Arch): гейт архитектурного дрейфа, который валит PR только на новых нарушениях зависимостей. Дизайн: intent-модельarchitecture.rules.yamlvs фактический граф зависимостей из.sln/.csproj, drift = actual − allowed, baseline-ratchet для существующего долга (fingerprint без file/line, канонический sort,rulesHash), tiered-диагностикиARCH###(детерминированные / эвристики / report-only), SARIF + markdown-отчёт. Жёсткие Non-goals: C4 только как renderer, без runtime-телеметрии, без dead-code гейтов, без второго rule-DSL. Плюс строка в индексеdocs/proposals/README.md.Тип изменения
Как проверено
python tests/run_tests.pyruff check .иmypypython scripts/<...>.py --selftest)Docs-only изменение: два markdown-файла, код не затронут — тесты/линтеры не применимы. Проверены относительные ссылки внутри proposal (P-001/P-013/P-015, notes/sarif-export.md) и формат индекса.
Связанные issue
Нет связанных issue. Proposal вырос из design-обсуждения детекции архитектурного дрейфа.
Чеклист
docs/proposals/README.mdдополненfeat:,fix:,docs:…)🤖 Generated with Claude Code
https://claude.ai/code/session_01JvV8eSjV4R1Qi1vGw6fDg2
Generated by Claude Code
Summary by CodeRabbit