Skip to content

Add Assassin's Creed: Odyssey#976

Closed
Kreyren wants to merge 3 commits into
PhoenicisOrg:masterfrom
Kreyrenicis:AC_Odyssey
Closed

Add Assassin's Creed: Odyssey#976
Kreyren wants to merge 3 commits into
PhoenicisOrg:masterfrom
Kreyrenicis:AC_Odyssey

Conversation

@Kreyren

@Kreyren Kreyren commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Credit: https://github.com/Haoose/UPLAY_GAME_ID/blob/master/README.md

Blocked by: #978

Blocked by: #881 -> Can't test!

@Kreyren Kreyren changed the title Add AC_Odyssey Add Assassin's Creed: Odyssey Jun 5, 2019
@Kreyren Kreyren force-pushed the AC_Odyssey branch 2 times, most recently from a1cdba1 to ed6b07e Compare June 6, 2019 01:38
@qparis

qparis commented Jun 6, 2019

Copy link
Copy Markdown
Member

Does the game run?

@Kreyren

Kreyren commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

Does the game run?

Blocked by: #978

@plata

plata commented Jun 6, 2019

Copy link
Copy Markdown
Collaborator

Blocking pr has been merged. Is this working now?

@Kreyren

Kreyren commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

Blocking pr has been merged. Is this working now?

Based on available info it should, but i didn't have the opportunity to test it on phoenicis yes so either push in testing or wait for me to test.

@plata

plata commented Jun 6, 2019

Copy link
Copy Markdown
Collaborator

In this case, please state this in the pull request description set the pull request to draft. Same for other pull requests like explained before.

@Kreyren

Kreyren commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

In this case, please state this in the pull request description set the pull request to draft. Same for other pull requests like explained before.

*push request, stop allowing github to confuse ppl :p

Insane, but okay

@plata

plata commented Jun 7, 2019

Copy link
Copy Markdown
Collaborator

Like explained before, we cannot accept untested pull requests. Therefore I will close this until it is tested.

@plata plata closed this Jun 7, 2019
@Kreyren

Kreyren commented Jun 8, 2019

Copy link
Copy Markdown
Contributor Author

Why do we have testing flag then.. w/e i will adapt for testing then..

@plata

plata commented Jun 8, 2019

Copy link
Copy Markdown
Collaborator

To quote from the documentation:

testingOperatingSystems
Operating systems for which the script is in beta. Should be set if you are unsure that the script will run properly for everybody (like if it requires a huge amount of hack, or if it is not compatible with a any graphics cards, etc…).

@Kreyren

Kreyren commented Jun 8, 2019

Copy link
Copy Markdown
Contributor Author

@plata seems fitting for all my AC scripts

@plata

plata commented Jun 9, 2019

Copy link
Copy Markdown
Collaborator

No. You cannot even be sure that it works at all.

@Kreyren

Kreyren commented Jun 10, 2019

Copy link
Copy Markdown
Contributor Author

@plata because phoenicis is unable to install any steam game, adapt patches for games that depends on them like league of legends and your wine has different results compared to system wine.

if you provided system wine and resolved the quickscripts i can quarantee you that specified version of game will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants