Skip to content

Add uplay option for Assassin's Creed: Brotherhood#971

Closed
Kreyren wants to merge 2 commits into
PhoenicisOrg:masterfrom
Kreyrenicis:ACB
Closed

Add uplay option for Assassin's Creed: Brotherhood#971
Kreyren wants to merge 2 commits into
PhoenicisOrg:masterfrom
Kreyrenicis:ACB

Conversation

@Kreyren

@Kreyren Kreyren commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Credit: https://github.com/Haoose/UPLAY_GAME_ID/blob/master/README.md

Blocked by: #978

Blocked by: Blocked by #881 -> Can't test!

@Kreyren Kreyren changed the title Add uplay option for ACB Add uplay option for Assassin's Creed: Brotherhood Jun 5, 2019
@qparis

qparis commented Jun 6, 2019

Copy link
Copy Markdown
Member

Does the game run?

@Kreyren

Kreyren commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

Does the game run?

Blocked by: #978

@plata

plata commented Jun 6, 2019

Copy link
Copy Markdown
Collaborator

Blocking pr has been merged. Is this working now?

@Kreyren

Kreyren commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

Blocking pr has been merged. Is this working now?

Based on available info it should, but i didn't have the ability to test it on phoenicis yep so either push in testing or wait for me to test it.

@plata

plata commented Jun 7, 2019

Copy link
Copy Markdown
Collaborator

Like explained before, we cannot accept untested pull requests. Therefore I will close this until it is tested.

@plata plata closed this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants