Restructure top nav into grouped dropdowns (desktop + mobile)#948
Merged
Conversation
Replace the flat top-menu link row with grouped navigation so content is easier to discover, per the new-website working doc. - About · Learn ▾ · Community ▾ · Get involved ▾ · Donate - Learn: Why this matters, Proposal, Our Strategy, FAQ - Community: Find your local group, Join an event (Luma) - Get involved: Take Action/Join, Start a local group - Desktop: click/hover dropdowns (NavDropdown), close on Escape & click-outside, active-section highlight — modeled on the existing LanguageSwitcher pattern. - Mobile (≤600px): hamburger toggles a panel with <details> accordion groups; tapping a link navigates and auto-closes (afterNavigate). - Menu is now data-driven via navItems.ts, shared by the wide & narrow navbars. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ Deploy Preview for pauseai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
This doesn't look intentional: |
The mobile panel's bottom section rendered as a bare divider with a lone unlabeled search icon, which read as a rendering glitch (PR review feedback). - Replace the shared `extras` snippet in the narrow panel with a dedicated `panelExtras` snippet: a full-width "Search" row (icon + label) styled like the other panel rows. - Tapping Search now closes the panel before opening the search modal (the snippet receives a close callback). - Anchor the language switcher's dropdown to the extras section (position: relative) so it opens in place on multi-locale builds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # src/routes/header.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Replaces the flat top-menu link row with grouped navigation so content is easier to discover, per the new-website working doc and the 18 May design mockup.
New menu structure
/about/learn· Proposal →/proposal· Our Strategy →/theory-of-change· FAQ →/faq/communities· Join an event → Luma (new tab)/join· Start a local group →/national-groups/donateHow it works on each device
Escape; the current section is highlighted. No hover-only behaviour, so it degrades gracefully. Modeled on the existingLanguageSwitcherpattern.<details>accordion; tapping a link navigates and auto-closes the panel (afterNavigate). Hamburger is white over the inverted hero.Implementation
The wide and narrow navbars now diverge, so the menu is data-driven via a shared
navItems.tsmodule.src/lib/components/navbar/navItems.ts,src/lib/components/navbar/NavDropdown.svelteWideNavbar,NarrowNavbar,Navbar(now take anitemsprop +extrassnippet),src/routes/header.sveltemessages/en.json— new shortheader_*labelsVerification
svelte-check, ESLint, Prettier clean on all touched files.aria-currenthighlight, inverted hamburger).Notes for reviewers
en); it renders in production where multiple locales exist.🤖 Generated with Claude Code