Quest rewards 0.5#2027
Open
rasmuskl wants to merge 1 commit into
Open
Conversation
…s. Add Tribal Medicine quest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
0.5 API now serves
quest_statsas aggregated instead of exact lines per quest. So the +30/30/40 lines for spirit becomes a single +100 line instead. This PR adds a simple greedy algorithm to configure quests in import by decomposing the rolled up values.Adds a simple disambiguation table for spirit specifically, since the 30+30+40 spirit values can result in wrong values with the greedy algorithm. An alternative solution would be to try all combinations, but I decided to keep it simple since it was only a single case to avoid the additional complexity.
Also added the new Tribal Medicine quest: https://poe2db.tw/us/Tribal_Medicine
Steps taken to verify a working solution:
Added new tests and tested in UI.