Trade: static stat data, better error handling, fix radius jewel#2020
Trade: static stat data, better error handling, fix radius jewel#2020vaisest wants to merge 11 commits into
Conversation
| _tradeStats = parsed.result | ||
|
|
||
| for _, cat in ipairs(_tradeStats) do | ||
| local file = io.open("./Data/trade_site_stats.json") |
There was a problem hiding this comment.
Could we have this auto-regenerate if it's not there? As it is, when regenerating QueryMods it seems like we'd have to delete that one so it regenerates, as well as redownload this file too if I'm reading this right. Seems like it should just be one or the other, or at the very least have them both regenerate in the same way.
There was a problem hiding this comment.
Sure, I'll fix that later today by making the client download it when QueryMods is regenerated
There was a problem hiding this comment.
Fixed with f8fc946. Now deleting the querymods file also downloads this json. It's also converted to lua as that seems to be preferred. Hopefully it won't cause an error at some point since the file is rather large
|
Rebased to dev. This PR probably isn't required to fix the trader working, but it does fix radius jewels and hardens the trader a bit towards future releases where new bases are introduced. I think rune matching is also better, but runes are frankly overly complex so I'm not sure about that |
vaisest
changed the title
2 participants
Description of the problem being solved:
Fixes crash and incorrect results in trader tool resulting from the trade stat categories changing
Steps taken to verify a working solution:
This will still need an update after more mods and augments are exported.