Skip to content

Fix Flowing Metal by also summing elemental DR #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaisest wants to merge 2 commits into
base: dev
Choose a base branch
from
+7 −1
Open

Fix Flowing Metal by also summing elemental DR #2016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c02837
Fix Flowing Metal by also summing elemental DR
vaisest May 29, 2026
28c1251
Longer lines
vaisest May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Modules/CalcDefence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2330,7 +2330,13 @@ function calcs.buildDefenceEstimations(env, actor)
--armour/PDR calculations
local armourReduct = 0
local impaleArmourReduct = 0
local percentOfArmourApplies = (not modDB:Flag(nil, "ArmourDoesNotApplyTo"..damageType.."DamageTaken") and modDB:Sum("BASE", nil, "ArmourAppliesTo"..damageType.."DamageTaken") or 0)
local percentOfArmourApplies = 0.0
if not modDB:Flag(nil, "ArmourDoesNotApplyTo" .. damageType .. "DamageTaken") then
percentOfArmourApplies = (modDB:Sum("BASE", nil, "ArmourAppliesTo" .. damageType .. "DamageTaken") or 0)
end
if not modDB:Flag(nil, "ArmourDoesNotApplyToElementalDamageTaken") and (damageType == "Fire" or damageType == "Cold" or damageType == "Lightning") then
percentOfArmourApplies = percentOfArmourApplies + (modDB:Sum("BASE", nil, "ArmourAppliesToElementalDamageTaken") or 0)
end
local effectiveAppliedArmour = (output.Armour * percentOfArmourApplies / 100) * (1 + output.ArmourDefense)
local effectiveArmourFromArmour = effectiveAppliedArmour;
local effectiveArmourFromOther = { }
Expand Down
Loading