Add martial artist rune slots#1991
Draft
vaisest wants to merge 11 commits into
Draft
Conversation
vaisest
force-pushed
the
martial-artist-runes
branch
from
6fda59a to
786c227
Compare
vaisest
force-pushed
the
martial-artist-runes
branch
from
786c227 to
9132caf
Compare
vaisest
commented
May 28, 2026
| ["you can socket (%d+) additional copies of each lineage support gem, in different skills"] = function(num) return { mod("MaxLineageCount", "BASE", num) } end, | ||
| ["can be modified while corrupted"] = {} | ||
| ["can be modified while corrupted"] = {}, | ||
| ["can tattoo runes onto your body, gaining"] = { flag("SocketRunesOnCharacter") }, |
Contributor
Author
There was a problem hiding this comment.
Not really sure if this is the correct way to do this. It would probably be possible to parse the socket counts, but this seems much simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting feedback as this is more a proof of concept. We don't know what they'll look like on import, but the slots purpose is a bit different from other item selectors, as you're not going to slot in actual items. This is still missing limit handling
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
What is still missing: