Skip to content

Draft: Add passive tree progression timeline#1930

Draft
TheClassified wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
TheClassified:feature/passive-point-allocation-order
Draft

Draft: Add passive tree progression timeline#1930
TheClassified wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
TheClassified:feature/passive-point-allocation-order

Conversation

@TheClassified
Copy link
Copy Markdown

@TheClassified TheClassified commented May 19, 2026

This PR adds passive tree progression similar to tools like Maxroll's PoE2 planner

Intention of the feature is to give the underlying support for exporting to the new .build format.

Build creators have the ability to respec without swapping to a new tree as well as editing the history via scrubbing through the timeline and placing new nodes.

image image

Any feedback is much appreciated, i tried to cover all the bases I could think of.

@TheClassified TheClassified force-pushed the feature/passive-point-allocation-order branch from 7664f35 to 1b0ad8e Compare May 19, 2026 20:03
@maksim789456
Copy link
Copy Markdown

Some feedback in my opinion:

  • Default state of passive progression must be hidden. It's kinda annoying see menu every time when u create build
  • On hide/show button missing gap relative to another element
image

I didn't quite understand the logic of progression bar.
For example, i allocate some nodes
image

At some point i changed my decisions and want change allocates. I place point in some point and take new nodes. But instead rewriting progression i just place new nodes at middle
image
Now question, how i must replace old allocated nodes?
it doesn't fit with logic of Maxroll's PoE2 planner. On maxroll when u make this actions u rewrite history, so maybe implement this behavior?

@maksim789456
Copy link
Copy Markdown

Also i got some bugs:

  • When hover over show/hide button Version: label color change to tooltip outline color
image
  • At some resolutions show/hide button almost full cropped and don't move on new line
image image

@TheClassified
Copy link
Copy Markdown
Author

Ty for the feedback, honestly I agree it should default to being hidden.

Will fix the breakpoints and default hidden.

To my knowledge Maxroll's also just insert in the middle of the progression, didin't see the need for an active button to activate, my assumption is if you scrub back and allocate at that point you want to do it at that point.

If you want to de-allocate nodes you can scrub to the end and de-allocate them, this just removes them from the entire progression.

Can you create an actual case for me to see the issue in action?

I can't seem to reproduce the Version text being tooltip colored
billede

@maksim789456
Copy link
Copy Markdown

To my knowledge Maxroll's also just insert in the middle of the progression

Nope, it's rewriting

maxroll_example.mp4

Can you create an actual case for me to see the issue in action?

I actually not have actual case for this one. Probably not issue at all, i just saw this behavior and it's confusing me.
Maybe u can add option in setting to change behavior when cursor on middle of progression line: or just add new allocations, or it rewrites as on Maxroll

I can't seem to reproduce the Version text being tooltip colored

Now i'm also cannot reproduce it xD. I run pob runtime through Proton, maybe this some way affect

@TheClassified
Copy link
Copy Markdown
Author

Not sure I am a fan of it scrapping the tree if you scrub and make another selection, I would love to hear others opinion on what the default behavior should be.

This could be in the form of what maxroll has, where the default behavior is to 'scrap' the tree in favor for the new path unless you actively hit "Edit history" which then appends at the scrubbed point.

@LocalIdentity do you have a take on this?

@TheClassified TheClassified force-pushed the feature/passive-point-allocation-order branch from 1b0ad8e to dbc509b Compare May 28, 2026 20:35
@LocalIdentity
Copy link
Copy Markdown
Contributor

I think trying to keep it be familiar to what Maxroll has is the best bet with a edit history button if you do want to wipe the tree

@TheClassified
Copy link
Copy Markdown
Author

TheClassified commented May 28, 2026

I'll look into adding the edit history button and changing the default behavior to replacing

@TheClassified
Copy link
Copy Markdown
Author

Let me know if this feels more intuitive 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants