Wrong route check on throughput:view#3059
Open
ramonsmits wants to merge 1 commit into
Open
Conversation
ThroughputStore.refresh gated the licensing/settings/test call on ApiRoutes.viewLicense (error:licensing:view). ServiceControl guards that endpoint with error:throughput:view instead. The gate must key on the exact route the endpoint requires, independent of which other routes the manifest grants — role-to-route bindings are not fixed and become fully flexible in future ServiceControl versions. The auto-refresh is mounted by ConfigurationMenuItem (always rendered), so a stale gate fired the request on load for any user whose manifest lacked the throughput route. Gate on ApiRoutes.viewThroughput instead. Add manifest-driven regression tests: granting the license route alone must not unlock the call; granting the throughput route must.
ramonsmits
force-pushed
the
fix-throughput-permission-gate
branch
from
139b881 to
cba900e
Compare
ramonsmits
changed the title
WilliamBZA
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThroughputStore.refreshgated thelicensing/settings/testcall onviewLicense, but the endpoint requireserror:throughput:view. Gate onviewThroughputinstead, so the request is blocked when the manifest lacks the throughput route. Adds manifest-driven regression tests.