Disable tabs if no access#3057
Merged
Merged
Conversation
ramonsmits
reviewed
Jul 6, 2026
| viewEndpoints: { method: "GET", path: "/api/endpoints" }, // error:endpoints:view (EndpointsMonitoringController) | ||
| manageThroughput: { method: "POST", path: "/api/licensing/settings/masks/update" }, // error:throughput:manage (LicensingController) | ||
| // ---- actions ---- | ||
| manageEndpointSettings: { method: "PATCH", path: "/api/endpointssettings/{}" }, |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I guess we can either check for GET or PATCH when doing the ability to manage endpoint settings. Is there a benefit to using the GET instead of PATCH?
Member
Author
There was a problem hiding this comment.
If we had a separate view endpoint settings to the manage endpoint settings, then we'd need to use the GET and the PATCH. But since we only have the manage endpoint settings which includes viewing the settings, I think we're fine with using PATCH for this
ramonsmits
approved these changes
Jul 6, 2026
dvdstelt
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to: