Skip to content

Fixing OutOfBounds errors on field.eval #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erikvansebille wants to merge 2 commits into from
Closed

Fixing OutOfBounds errors on field.eval #2665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b2427
Changing OUT_OF_BOUNDS error codes to be extremely large
erikvansebille Jun 16, 2026
b49ee34
Adding unit test for OutOfBounds field.eval
erikvansebille Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/parcels/_core/index_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
from parcels._core.xgrid import XGrid


GRID_SEARCH_ERROR = -3
LEFT_OUT_OF_BOUNDS = -2
RIGHT_OUT_OF_BOUNDS = -1
GRID_SEARCH_ERROR = np.iinfo(np.int32).max - 3
LEFT_OUT_OF_BOUNDS = np.iinfo(np.int32).max - 2
RIGHT_OUT_OF_BOUNDS = np.iinfo(np.int32).max - 1


def _search_1d_array(
Expand Down
16 changes: 16 additions & 0 deletions tests/test_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from parcels import Field, UxGrid, VectorField, XGrid
from parcels._core.fieldset import FieldSet
from parcels._datasets.structured.generated import simple_UV_dataset
from parcels._datasets.structured.generic import T as T_structured
from parcels._datasets.structured.generic import datasets as datasets_structured
from parcels._datasets.unstructured.generic import datasets as datasets_unstructured
Expand Down Expand Up @@ -270,6 +271,21 @@ def test_field_constant_in_time():
assert np.isclose(P1, P2)


def test_field_eval_out_of_bounds():
"""Test that Field.eval returns IndexError when queried outside the grid boundaries."""
ds = simple_UV_dataset(mesh="flat")
fieldset = FieldSet.from_sgrid_conventions(ds, mesh="flat")

with pytest.raises(IndexError, match=".* is out of bounds.*"):
fieldset.U.eval(0.0, 0.0, 0.0, 5e6)

with pytest.raises(IndexError, match=".* is out of bounds.*"):
fieldset.U.eval(0.0, 0.0, 5e6, 0.0)

with pytest.raises(IndexError, match=".* is out of bounds.*"):
fieldset.U.eval(0.0, 5e6, 0.0, 0.0)


def test_field_unstructured_grid_creation(): ...


Expand Down
Loading