Fix sshd runtime directory permissions#30
Merged
Conversation
Ensure the bundled runner normalizes /var/run/sshd ownership and mode after creation so sshd can start even when the container umask is permissive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the bundled SSH runner’s startup by ensuring /var/run/sshd is created with safe ownership and permissions even when the container’s umask would otherwise produce permissive modes that can prevent sshd from starting.
Changes:
- Normalize
/var/run/sshdtoroot:rootwith mode0755insrc/runner/ssh-server.sh. - Add a regression test that asserts the bundled runner script includes the directory creation + normalization steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/runtime.test.ts |
Adds a regression test asserting the bundled runner script enforces correct /var/run/sshd ownership and mode. |
src/runner/ssh-server.sh |
Applies chown root:root and chmod 0755 after creating /var/run/sshd to prevent umask-dependent failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PabloZaiden
enabled auto-merge (squash)
June 30, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing