Update filename handling in InferableTypeStage for filespec#198
Merged
Conversation
Member
|
Please add a test for this |
hobu
reviewed
Jan 28, 2026
Raise ValueError if 'path' is missing in filename dict
Contributor
Author
Will try to do so. Should I add it to the |
Member
Yep. Just verify that the three possible combos of filespec usage are tested |
Added assertions to validate reader and writer types for filespec format.
Contributor
Author
|
@hobu Test added (also removed unused import |
Contributor
Author
|
Not sure how the authentication is achieved though. The "headers" arg should be added to the options but with what key name exactly ? |
Member
|
I have updated this to provide full FileSpec support for PDAL 2.9+ and conditionalize its behavior for anything below that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue #197
When a reader stage is build using filespec, the type inference is tried on the whole dict and thus fails. Instead, the inference should be made on the "path" keyword